Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon button remove default green #10573

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented Jan 24, 2022

Description

Remove Default color from Icon Button Widget

Fixes #10309

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: bug/icn-btn-handle-no-color 
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)
🔴 app/client/src/widgets/IconButtonWidget/widget/index.tsx 48.39 (-1.61) 0 (0) 60 (0) 48.28 (-1.72)

@techbhavin techbhavin added App Viewers Pod This label assigns issues to the app viewers pod UI Building Pod labels Jan 24, 2022
@vercel
Copy link

vercel bot commented Jan 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/9SZvjX62Jv6Zb1vvPRkSD4TcAYU6
✅ Preview: https://appsmith-git-bug-icn-btn-handle-no-color-get-appsmith.vercel.app

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=163b75a

@github-actions github-actions bot added the Bug Something isn't working label Jan 24, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1738278150.
Workflow: Appsmith External Integration Test Workflow.
Commit: 163b75a.
PR: 10573.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1738278150.
Commit: 163b75a.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2616.27 2189.48 2250.61 2075.8 2156.46 2257.72 9.31 8.32
painting 48.69 18 24.62 30.5 54.69 35.3 44.62 39.89
rendering 448.49 329.3 368.48 317.54 332.97 359.36 14.84 13.27
Edit input
scripting 302.93 399.59 348.68 354.6 320.47 345.25 10.70 9.57
painting 36.9 7.15 6.74 9.88 3.63 12.86 105.91 94.71
rendering 13.74 21.44 18.79 19.47 16.97 18.08 16.10 14.38
Clear input
scripting 752.26 793.4 758.73 796.34 788.15 777.78 2.66 2.38
painting 21.88 16.21 12.67 15.21 23.53 17.9 25.75 23.02
rendering 223.55 213.45 219.09 236.06 220.73 222.58 3.77 3.37
Edit input again
scripting 297.61 385.15 295.1 284.93 281.79 308.92 13.96 12.49
painting 6.07 15.54 5.45 4.97 7.97 8 54.63 48.88
rendering 23.24 29.55 26.75 18.66 17.16 23.07 22.71 20.33

@somangshu somangshu requested review from somangshu and removed request for jsartisan January 25, 2022 05:54
Copy link
Contributor

@somangshu somangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somangshu
Copy link
Contributor

@techbhavin Tested the deploy preview, Everything looks good, Only one point:

  • For the older buttons, Setting to noColor still has the hover color. This is not reproducible for the new buttons

Screenshot 2022-01-25 at 11 31 32 AM

@somangshu
Copy link
Contributor

  • For the older buttons, Setting to noColor still has the hover color. This is not reproducible for the new buttons

@techbhavin I figured this happens when there is an onClick action configured, I am seeing the hover color even when the noColor is set

@YogeshJayaseelan
Copy link
Contributor

@techbhavin Verified this and it is working as expected

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=0b91527

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1756181160.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0b91527.
PR: 10573.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1756181160.
Commit: 0b91527.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2662.84 2256.3 2194.19 2159.71 2202.63 2295.13 9.08 8.12
painting 29.96 26.76 36.24 42.58 29.29 32.97 19.44 17.38
rendering 440.44 317.04 313.68 318.68 341.51 346.27 15.53 13.89
Edit input
scripting 403.49 329.77 340.63 363.71 393.15 366.15 8.75 7.82
painting 12.4 4.01 6.04 13.25 36.83 14.51 90.28 80.77
rendering 22.17 12.4 14.22 20.42 13.83 16.61 26.37 23.54
Clear input
scripting 786.47 762.47 802.95 1068.57 776.57 839.41 15.36 13.74
painting 15.17 9.65 22.81 12.76 6.77 13.43 45.64 40.80
rendering 230.91 215.37 227.3 220.15 229.77 224.7 2.98 2.66
Edit input again
scripting 315.74 322.64 312.68 318.36 325.94 319.07 1.66 1.49
painting 5.66 21.89 11.61 6.88 6.37 10.48 64.79 58.02
rendering 20.47 20.8 21.02 27.01 26.1 23.08 13.82 12.39

@techbhavin techbhavin merged commit 45d3704 into release Jan 27, 2022
@techbhavin techbhavin deleted the bug/icn-btn-handle-no-color branch January 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Iconbutton widget when changed to 'no color' still remains green
3 participants