-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icon button remove default green #10573
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/9SZvjX62Jv6Zb1vvPRkSD4TcAYU6 |
/ok-to-test sha=163b75a |
Unable to find test scripts. Please add necessary tests to the PR. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1738278150. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1738278150. Click to view performance test results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@techbhavin Tested the deploy preview, Everything looks good, Only one point:
|
@techbhavin I figured this happens when there is an onClick action configured, I am seeing the hover color even when the noColor is set |
@techbhavin Verified this and it is working as expected |
/ok-to-test sha=0b91527 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1756181160. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1756181160. Click to view performance test results
|
Description
Fixes #10309
Type of change
Checklist:
Test coverage results 🧪
⚪ Total coverage has not changed