Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add query parameters to Options/Form #10681

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

danieldare
Copy link
Contributor

@danieldare danieldare commented Jan 27, 2022

Description

Display Query Parameters data on the API Section cards and form.

Fixes #(9930)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/authenticated-api-query-parameters 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 55.04 (-0.01) 36.66 (-0.01) 34.97 (0) 55.44 (-0.01)
🔴 app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx 42.19 (-2.07) 45 (-5) 0 (0) 45.61 (-2.54)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@vercel
Copy link

vercel bot commented Jan 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/Ey5iqAqtkBEGEXQqNX1E45JSbyGH
✅ Preview: https://appsmith-git-fix-authenticated-api-query-pa-6ae913-get-appsmith.vercel.app

@danieldare danieldare self-assigned this Jan 27, 2022
@github-actions github-actions bot added the Bug Something isn't working label Jan 27, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@danieldare danieldare changed the title fix: add query parameters to options fix: Add query parameters to Options/Form Jan 27, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@danieldare
Copy link
Contributor Author

/ok-to-test sha=c15a1ea

@danieldare
Copy link
Contributor Author

/ok-to-test sha=5cfc81a

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1761201283.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5cfc81a.
PR: 10681.

@nidhi-nair nidhi-nair removed their request for review January 28, 2022 11:42
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1761201283.
Commit: 5cfc81a.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2697.66 2170.22 2140.57 2095.33 2136.66 2248.09 11.24 10.06
painting 38.68 15.47 53.91 17 21.05 29.22 56.84 50.86
rendering 426.56 363.76 282.49 298.36 308.58 335.95 17.61 15.75
Edit input
scripting 279.66 292.02 269 291.04 325.97 291.54 7.35 6.57
painting 10.67 6.07 33.28 18.26 18.86 17.43 59.38 53.13
rendering 23.3 14.97 13.17 15.86 17.97 17.05 22.87 20.41
Clear input
scripting 692.43 716.1 682.88 728.3 766.83 717.31 4.61 4.13
painting 11.12 18.5 23.65 6.26 12.58 14.42 46.88 41.89
rendering 209.09 210.55 225.53 191.92 206.62 208.74 5.73 5.13
Edit input again
scripting 351.59 278.56 372.16 285.49 274.41 312.44 14.68 13.14
painting 15.17 6.01 6.18 5.04 5.01 7.48 57.89 51.74
rendering 19.18 14.96 22.58 19.22 23.81 19.95 17.34 15.49

@danieldare danieldare merged commit 20f5a7f into release Jan 28, 2022
@danieldare danieldare deleted the fix/authenticated-api-query-parameters branch January 28, 2022 13:03
@nidhi-nair nidhi-nair added the BE Coders Pod Issues related to users writing code to fetch and update data label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants