Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy evaluation version for cloned application from the source application to fix dynamic dynamic binding evaluation to support escaped characters without double escape #10702

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Jan 28, 2022

Description

Evaluation version was not getting copied to the cloned application which was resulting in error state for the dynamic binding for the escaped characters without double escapes. This PR clones evaluationVersion field from the src application to cloned application

Fixes #2862

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

JUnit test-case
Manual test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abhvsn abhvsn self-assigned this Jan 28, 2022
@vercel
Copy link

vercel bot commented Jan 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/FbDto7tj5YpXAM6powyWNdJxu3yu
✅ Preview: https://appsmith-git-fix-dynamic-binding-eval-clone-app-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Jan 28, 2022
@abhvsn
Copy link
Contributor Author

abhvsn commented Jan 28, 2022

/ok-to-test sha=667e4ca

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1760109307.
Workflow: Appsmith External Integration Test Workflow.
Commit: 667e4ca.
PR: 10702.

@abhvsn abhvsn enabled auto-merge (squash) January 28, 2022 06:27
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1760109307.
Commit: 667e4ca.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2233.89 1993.17 2009.7 2067.38 2034.47 2067.72 4.69 4.20
painting 36.49 17.18 18.46 34.6 32.79 27.9 33.37 29.86
rendering 380.29 295.74 287.05 271.24 278.37 302.54 14.69 13.14
Edit input
scripting 241.92 289.61 306.64 274.07 260.2 274.49 9.16 8.19
painting 7.23 17.44 20.7 7.84 6.91 12.02 54.41 48.67
rendering 9.33 14.94 11.09 20.51 11.24 13.42 33.23 29.73
Clear input
scripting 664.65 706.78 664.58 680.46 638.66 671.03 3.72 3.33
painting 13.34 12.37 17.16 8.8 5.61 11.46 38.57 34.47
rendering 190.1 189.26 199.33 185.87 200.26 192.96 3.34 2.99
Edit input again
scripting 277.35 249.11 337.5 343.23 269.38 295.31 14.37 12.85
painting 4.15 4.82 6.67 6.04 10.19 6.37 36.89 32.97
rendering 16.21 25.12 20.07 14.83 13.14 17.87 26.80 23.95

@mohanarpit mohanarpit changed the title fix: Copy evaluation version for cloned application from the source application to fix dynamic dynamic binding evaluation to support escaped characters without double escapes fix: Copy evaluation version for cloned application from the source application to fix dynamic dynamic binding evaluation to support escaped characters without double escape Jan 28, 2022
@abhvsn abhvsn merged commit 07082f6 into release Jan 28, 2022
@abhvsn abhvsn deleted the fix/dynamic-binding-eval-clone-app branch January 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Modify dynamic binding evaluation to support escaped characters without double escapes
2 participants