Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recaptcha script not loading #10764

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

vicky-primathon
Copy link
Contributor

@vicky-primathon vicky-primathon commented Jan 31, 2022

Description

Fix loading of recaptcha script

Fixes #10716

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@vicky-primathon vicky-primathon added Bug Something isn't working App Viewers Pod This label assigns issues to the app viewers pod Critical This issue needs immediate attention. Drop everything else UI Building Pod labels Jan 31, 2022
@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/HoWYwuXmP25zxebjeFQ9EVrFNT1s
✅ Preview: https://appsmith-git-fix-recaptcha-script-load-get-appsmith.vercel.app

@vicky-primathon vicky-primathon changed the title Fix recaptch script not loading issue fix: recaptcha script not loading Jan 31, 2022
@github-actions github-actions bot removed the Bug Something isn't working label Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Bug Something isn't working label Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@vicky-primathon
Copy link
Contributor Author

/ok-to-test sha=52dfbb9

@somangshu somangshu removed the Critical This issue needs immediate attention. Drop everything else label Jan 31, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1772536807.
Workflow: Appsmith External Integration Test Workflow.
Commit: 52dfbb9.
PR: 10764.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1772536807.
Commit: 52dfbb9.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2564.63 2533.65 2559.54 2517.8 2537.35 2542.59 0.76 0.68
painting 9.83 12.59 10.56 27.49 14.78 15.05 47.97 42.86
rendering 289.45 321.92 314.1 272.18 297.04 298.94 6.62 5.92
Edit input
scripting 322.25 391.79 353.45 448.36 401.96 383.56 12.55 11.23
painting 13.48 23.26 4.99 7.34 25.26 14.87 61.53 55.01
rendering 14.5 16.39 14.43 17.57 19.97 16.57 14.00 12.49
Clear input
scripting 925.05 867.71 881.64 847.53 889.42 882.27 3.26 2.91
painting 7.37 7.47 19.25 9.98 11.87 11.19 43.61 39.05
rendering 224.71 216.51 208.35 213.23 212.26 215.01 2.86 2.56
Edit input again
scripting 357.46 772.43 362.58 383.41 321.94 439.56 42.63 38.13
painting 16.66 16.1 5.86 26.16 5.37 14.03 61.72 55.24
rendering 21.2 23.37 23.22 27.75 20.78 23.26 11.87 10.62

@mohanarpit mohanarpit merged commit 8e174f7 into release Jan 31, 2022
@mohanarpit mohanarpit deleted the fix/recaptcha-script-load branch January 31, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Recaptcha is not working on release
4 participants