Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 9414 Firestore where clause not fetching numbers #10775

Merged
merged 6 commits into from
Feb 8, 2022

Conversation

leotom2000
Copy link
Contributor

Description

Fixed issue with Firestore in fetching data while using numbers in the where condition.
Other Fixes made in the where condition :

  1. When using Boolean
  2. When using Date
  3. When Using Timestamp
  4. When given space in the key
  5. When Space given in the Value

Fixes #9414

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/AooD9uN2AQVRhTkuS3aMcspEiJLq
✅ Preview: https://appsmith-git-fix-9414-firestorewhereclassfo-71713b-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Jan 31, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sumitsum sumitsum changed the title fix: 9414 Firestore where class not fetching numbers fix: 9414 Firestore where clause not fetching numbers Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@sumitsum sumitsum removed the request for review from nidhi-nair February 2, 2022 08:43
@sumitsum
Copy link
Contributor

sumitsum commented Feb 7, 2022

/ok-to-test sha=e64d975

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1804223002.
Workflow: Appsmith External Integration Test Workflow.
Commit: e64d975.
PR: 10775.

@sumitsum
Copy link
Contributor

sumitsum commented Feb 7, 2022

LGTM. Requesting someone to approve since Github is throwing internal error on me.

@nidhi-nair nidhi-nair removed the request for review from sumitsum February 7, 2022 07:56
@sumitsum sumitsum enabled auto-merge (squash) February 8, 2022 04:36
@sumitsum sumitsum merged commit 6e76874 into release Feb 8, 2022
@sumitsum sumitsum deleted the fix-9414-Firestore_where_class_For_Numbers branch February 8, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Firestore where clause doesn't seem to work
4 participants