Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: Added iFrame to load Base64 PDF data in document viewer widget" #10786

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented Feb 1, 2022

Reverts #10770

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: revert-10770-fix/pdf-document-viewer 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 55 (0) 36.48 (-0.01) 34.71 (0) 55.4 (0)
🔴 app/client/src/utils/WorkerUtil.ts 89.76 (0) 70.59 (-1.96) 100 (0) 93.33 (0)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)
🟢 app/client/src/widgets/DocumentViewerWidget/component/index.tsx 40.37 (-1.16) 45.65 (4.83) 16.67 (0) 42.11 (-1.16)

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/FTufrXnVqoCz3zqEVA55utTcryaD
✅ Preview: https://appsmith-git-revert-10770-fix-pdf-document-viewer-get-appsmith.vercel.app

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=4b3a37f

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1777485698.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4b3a37f.
PR: 10786.

@somangshu somangshu changed the title Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget" fix: Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget" Feb 1, 2022
@techbhavin techbhavin changed the title fix: Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget" revert : "fix: Added iFrame to load Base64 PDF data in document viewer widget" Feb 1, 2022
Copy link
Contributor

@somangshu somangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techbhavin please check the original issue in the DP once its ready. We can merge then

@github-actions github-actions bot added the Bug Something isn't working label Feb 1, 2022
@techbhavin techbhavin changed the title revert : "fix: Added iFrame to load Base64 PDF data in document viewer widget" revert: "fix: Added iFrame to load Base64 PDF data in document viewer widget" Feb 1, 2022
@github-actions github-actions bot removed the Bug Something isn't working label Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1777485698.
Commit: 4b3a37f.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Mean SD.Sample SD.Population
Click on table row
scripting 2254.69 2558.74 2099.5 2075.9 2050.78 2207.92 9.58 8.57
painting 21.07 51.12 9.12 14.05 15.23 22.12 75.77 67.77
rendering 333.91 418.45 252.59 318.79 232.84 311.32 23.63 21.14
Edit input
scripting 334.54 276.05 321.01 316.82 339.07 317.5 7.85 7.02
painting 10.42 16.55 12.55 40.68 16.12 19.26 63.55 56.85
rendering 19.82 13.65 23.34 16.49 21.39 18.94 20.49 18.32
Clear input
scripting 731.65 807.8 687.51 734.35 763.22 744.91 5.96 5.33
painting 9.03 6.65 9.23 9.51 6.51 8.19 18.07 16.12
rendering 176.65 192.12 172.94 224.13 186.3 190.43 10.67 9.54
Edit input again
scripting 300.55 300.85 296.35 341.26 292.81 306.36 6.46 5.78
painting 6.09 16.07 4.3 7.17 9.41 8.61 52.96 47.39
rendering 27.62 27.54 20.34 27.42 24.08 25.4 12.60 11.26

@somangshu somangshu merged commit 4e28b48 into release Feb 1, 2022
@somangshu somangshu deleted the revert-10770-fix/pdf-document-viewer branch February 1, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants