Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiselection in table widget #10838

Merged
merged 2 commits into from
Feb 8, 2022
Merged

fix: Multiselection in table widget #10838

merged 2 commits into from
Feb 8, 2022

Conversation

Tooluloope
Copy link
Contributor

@Tooluloope Tooluloope commented Feb 2, 2022 •
edited by github-actions bot

Description

fix Select and deselect all in table widget when multiselection is enabled

Fixes #10669

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: fix/select-and-deselect-in-table-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.03 (0) 36.37 (0.01) 34.71 (0) 55.41 (0)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)
🔴 app/client/src/widgets/TableWidget/widget/index.tsx 29.74 (0.1) 9.48 (0) 28.85 (-0.56) 29.4 (0.11)

@vercel
Copy link

vercel bot commented Feb 2, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/6s9xC5K3KH22NbJmCXn4P3YYazNC
✅ Preview: https://appsmith-git-fix-select-and-deselect-in-tab-f3aa3c-get-appsmith.vercel.app

@Tooluloope Tooluloope added the App Viewers Pod This label assigns issues to the app viewers pod label Feb 2, 2022
@github-actions github-actions bot added the Bug Something isn't working label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@riodeuno
Copy link
Contributor

riodeuno commented Feb 7, 2022

@Tooluloope The code looks good to me.

  1. We will have to write a cypress test to avoid regressions in this scenario.
  2. Can we verify by looking at the git blame of this file, to see whey we kept the default selected rows, selected, even when deselecting all? We might be able to find a relevant issue which was closed to figure out the rationale.

@chandannkumar
Copy link

Tested and working fine

@Tooluloope
Copy link
Contributor Author

@Tooluloope The code looks good to me.

  1. We will have to write a cypress test to avoid regressions in this scenario.
  2. Can we verify by looking at the git blame of this file, to see whey we kept the default selected rows, selected, even when deselecting all? We might be able to find a relevant issue which was closed to figure out the rationale.

@riodeuno

  1. Added test cases already
  2. Feature/table multi select #5074 it was just a feature request.

@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=6205000

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1812549738.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6205000.
PR: 10838.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1812549738.
Commit: 6205000.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 3496.43 2653.01 2665.48 2764.88 2912.39 2764.88 2898.44 12.08 10.80
painting 15.97 16.31 12.3 13.06 31.77 15.97 17.88 44.52 39.82
rendering 549.63 364.62 347.68 410.29 382.9 382.9 411.02 19.68 17.60
Edit input
scripting 484.35 451.91 432.6 349.56 509.47 451.91 445.58 13.75 12.30
painting 20.66 5.76 7.7 27.35 9.71 9.71 14.24 65.52 58.64
rendering 25.27 23.28 20.49 25.75 19.11 23.28 22.78 12.77 11.46
Clear input
scripting 965.79 972.79 979.56 895.9 914.08 965.79 945.62 4.01 3.59
painting 20.8 9.18 8.86 20.07 14.92 14.92 14.77 38.73 34.60
rendering 261.19 267.19 279.91 245.71 265.1 265.1 263.82 4.67 4.18
Edit input again
scripting 377.42 414.48 410.27 368.14 366.45 377.42 387.35 6.01 5.37
painting 17.17 14.7 18.09 6.34 12.64 14.7 13.79 33.94 30.31
rendering 25.6 26.66 25.86 20.75 32.29 25.86 26.23 15.67 13.99

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1812549738.
Commit: 6205000.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 3496.43 2653.01 2665.48 2764.88 2912.39 2764.88 2898.44 12.08 10.80
painting 15.97 16.31 12.3 13.06 31.77 15.97 17.88 44.52 39.82
rendering 549.63 364.62 347.68 410.29 382.9 382.9 411.02 19.68 17.60
Edit input
scripting 484.35 451.91 432.6 349.56 509.47 451.91 445.58 13.75 12.30
painting 20.66 5.76 7.7 27.35 9.71 9.71 14.24 65.52 58.64
rendering 25.27 23.28 20.49 25.75 19.11 23.28 22.78 12.77 11.46
Clear input
scripting 965.79 972.79 979.56 895.9 914.08 965.79 945.62 4.01 3.59
painting 20.8 9.18 8.86 20.07 14.92 14.92 14.77 38.73 34.60
rendering 261.19 267.19 279.91 245.71 265.1 265.1 263.82 4.67 4.18
Edit input again
scripting 377.42 414.48 410.27 368.14 366.45 377.42 387.35 6.01 5.37
painting 17.17 14.7 18.09 6.34 12.64 14.7 13.79 33.94 30.31
rendering 25.6 26.66 25.86 20.75 32.29 25.86 26.23 15.67 13.99

@Tooluloope Tooluloope merged commit 453974b into release Feb 8, 2022
@Tooluloope Tooluloope deleted the fix/select-and-deselect-in-table-widget branch February 8, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Select all/deselect all do not work for the default row in table widget if it is changed
4 participants
@Tooluloope @riodeuno @chandannkumar @sbalaji1192