-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix refresh token flow in REST API OAuth #10875
Conversation
1. where to add client creds on refresh token flow. 2. if scope needs to be sent on refresh token flow.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/CXTeAFCcz2m2H4jjw41cVG86xAqZ |
LGTM, would recommend that the client adds these into a separate "Advanced" section since these settings won't usually be helpful for providers that follow the spec. |
- add dropdown components to capture advanced settings
add handling for client credentials based authorization update form.json
app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx
Outdated
Show resolved
Hide resolved
...th-plugins/restApiPlugin/src/main/java/com/external/connections/OAuth2ClientCredentials.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a few UI changes
…mithorg/appsmith into fix/fix_refresh_token_10493
/ok-to-test sha=b023cbe |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1812674860. |
/ok-to-test sha=b023cbe |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1812919964. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1812919964. Click to view performance test results
|
Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com> (cherry picked from commit aa22904)
Description
Fixes #10493
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased