Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added disable signup form config #10942

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Feb 7, 2022

Description

Added disable signup form config

Fixes #11007

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added env variable APPSMITH_SIGNUP_DISABLED with value false to check if it works as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: hotfix/disable-signup-config 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.99 (0) 36.32 (0.01) 34.68 (0) 55.37 (0)
🟢 app/client/src/ce/configs/index.ts 95.24 (0) 86.67 (0.26) 100 (0) 97.3 (0)

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/FMniJhXRMCY6pc61brGuDepcQxG1
✅ Preview: https://appsmith-git-hotfix-disable-signup-config-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=1c8d804

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1813685501.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1c8d804.
PR: 10942.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1813685501.
Commit: 1c8d804.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2308.65 2219.52 2267.16 2238.63 2348.02 2267.16 2276.4 2.29 2.05
painting 9.76 8.84 19.62 13.4 14 13.4 13.12 32.47 29.04
rendering 334 267.76 280.42 310.69 281.82 281.82 294.94 9.12 8.16
Edit input
scripting 359.18 310.13 291.59 334.39 328.18 328.18 324.69 7.86 7.03
painting 43.41 9.29 5.16 16.94 34.85 16.94 21.93 75.42 67.44
rendering 18.93 16.36 14 20.73 15.14 16.36 17.03 16.21 14.50
Clear input
scripting 785.78 785.31 827.33 769.29 787.25 785.78 790.99 2.73 2.44
painting 11.63 5.97 8.19 6.8 9.83 8.19 8.48 27.00 24.17
rendering 196.27 193.09 207.99 225.46 204.95 204.95 205.55 6.17 5.52
Edit input again
scripting 303.09 310.26 309.93 326.14 334.95 310.26 316.87 4.16 3.72
painting 5.12 8.41 5.54 7.96 7.69 7.69 6.94 21.61 19.31
rendering 19.43 22.14 21.04 27.57 23.97 22.14 22.83 13.67 12.22

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=1c8d804

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1813924569.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1c8d804.
PR: 10942.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=1c8d804

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1816175556.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1c8d804.
PR: 10942.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1816175556.
Commit: 1c8d804.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Edit input
scripting 293.49 409.23 325.04 301.43 284.23 301.43 322.68 15.71 14.05
painting 7.2 9.5 24.87 5.25 4.48 7.2 10.26 81.77 73.20
rendering 15.75 23.76 16.91 13.82 15 15.75 17.05 22.99 20.53
Clear input
scripting 766.2 742.91 762.14 835.98 785.76 766.2 778.6 4.56 4.08
painting 24.54 6.97 7.26 13.44 11.08 11.08 12.66 56.64 50.71
rendering 186.51 196.02 186.35 191.01 193.43 191.01 190.66 2.23 1.99
Edit input again
scripting 319.37 295.42 308.64 266.98 290.69 295.42 296.22 6.70 6.00
painting 5.41 5.9 29.59 9.51 4.73 5.9 11.03 95.56 85.49
rendering 33.9 22.03 28.35 28.5 20.56 28.35 26.67 20.32 18.15
Click on table row
scripting 2184.35 2217.8 2910.48 2184.25 2213.28 2213.28 2342.03 13.58 12.15
painting 13.79 10.8 36.89 58.24 29.1 29.1 29.76 64.58 57.76
rendering 278.03 251.49 409.53 253.22 259.04 259.04 290.26 23.26 20.80

@sbalaji1192
Copy link
Contributor

FE changes LGTM

@ankitakinger ankitakinger merged commit 81760a9 into release Feb 9, 2022
@ankitakinger ankitakinger deleted the hotfix/disable-signup-config branch February 9, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Default state of users can signup should be true in Admin settings page
2 participants