Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search closes in dropdown when search text contains space #10945

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

vicky-primathon
Copy link
Contributor

@vicky-primathon vicky-primathon commented Feb 7, 2022

Description

Fixes #9597

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/dropdown-filter 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.04 (0.01) 36.38 (0.01) 34.71 (0) 55.42 (0.01)
🟢 app/client/src/components/ads/Dropdown.tsx 82.21 (0.58) 61.85 (0.34) 69.44 (0) 81.03 (0.5)

@vicky-primathon vicky-primathon added Bug Something isn't working App Viewers Pod This label assigns issues to the app viewers pod UI Building Pod labels Feb 7, 2022
@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/5DL51fjMNtm8mnVTMh2xQeBTLr5S
✅ Preview: https://appsmith-git-fix-dropdown-filter-get-appsmith.vercel.app

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@chandannkumar
Copy link

Tested the PR and it is working fine

@vicky-primathon
Copy link
Contributor Author

/ok-to-test sha=db1700e

@vicky-primathon
Copy link
Contributor Author

/ok-to-test sha=203fcf7

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1812279527.
Workflow: Appsmith External Integration Test Workflow.
Commit: 203fcf7.
PR: 10945.

@vicky-primathon vicky-primathon changed the title fix: disable closing dropdown on space fix: Search closes in dropdown when search text contains space Feb 9, 2022
@vicky-primathon vicky-primathon merged commit e4e7c59 into release Feb 9, 2022
@vicky-primathon vicky-primathon deleted the fix/dropdown-filter branch February 9, 2022 07:02
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The search filter disappears when the user searches any country with invalid spelling
3 participants