Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Switch Widget #1760

Closed
Nikhil-Nandagopal opened this issue Nov 17, 2020 · 3 comments · Fixed by #2999
Closed

[Feature] Switch Widget #1760

Nikhil-Nandagopal opened this issue Nov 17, 2020 · 3 comments · Fixed by #2999
Assignees
@marks0351
Labels
App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request Verified When issue is retested post its fixed
Projects
UI Building

Comments

@Nikhil-Nandagopal
Copy link
Contributor

Summary

Users want a switch widget as an alternative to the checkbox widget due to the aesthetic appeal

Additional Context

The switch widget will contain the following properties

label: string
isSelected: boolean
isVisible: boolean
isDisabled: boolean
isRequired: boolean
onSelectionChange:ActionSelector

https://www.figma.com/file/moGQyQffFfyUhHUMO9xqn3/Appsmith-v1.0-Final?node-id=1768%3A5093
@Nikhil-Nandagopal Nikhil-Nandagopal added Enhancement New feature or request App Viewers Pod This label assigns issues to the app viewers pod labels Nov 17, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal self-assigned this Nov 17, 2020
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Nov 17, 2020
@github-actions
Copy link

We have found issues that are potential duplicates:

  • [[Feature] iframe Widget #1726] [Feature] iFrame Widget (77.78%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

@github-actions github-actions bot mentioned this issue Nov 17, 2020
Closed
@Nikhil-Nandagopal Nikhil-Nandagopal removed the potential-duplicate This label marks issues that are potential duplicates of already open issues label Nov 17, 2020
@github-actions github-actions bot mentioned this issue Nov 18, 2020
Closed
@Nikhil-Nandagopal Nikhil-Nandagopal added the Community Reported issues reported by community members label Nov 18, 2020
@mohanarpit mohanarpit added this to To do in [Now] Widgets via automation Nov 18, 2020
@areyabhishek areyabhishek added Needs Design needs design or changes to design and removed Needs Design needs design or changes to design labels Nov 30, 2020
@mohanarpit mohanarpit moved this from To do to Up Next in [Now] Widgets Nov 30, 2020
@mohanarpit mohanarpit moved this from Up Next to To do in [Now] Widgets Dec 14, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal removed this from To do in [Now] Widgets Dec 30, 2020
@areyabhishek areyabhishek added this to Needs triage in UI Building Dec 31, 2020
@riodeuno riodeuno moved this from Needs triaging to Needs Design in UI Building Jan 8, 2021
@areyabhishek areyabhishek moved this from Needs Design to In design and documentation in UI Building Jan 11, 2021
@marks0351 marks0351 mentioned this issue Feb 12, 2021
Merged
7 tasks
@riodeuno riodeuno moved this from In design and documentation to In Development in UI Building Feb 12, 2021
@marks0351
Copy link
Member

@Nikhil-Nandagopal Can we have 'isToggledOn' or 'isSwitchedOn' instead of 'isSelected', 'onChange' instead of 'onSelectionChange'?

@Nikhil-Nandagopal
Copy link
Contributor Author

@marks0351 Yes makes sense 👍

@riodeuno riodeuno moved this from In Development to In Review and Testing in UI Building Feb 12, 2021
UI Building automation moved this from In Review and Testing to Closed Feb 16, 2021
@close-label close-label bot added the QA Needs QA attention label Feb 16, 2021
@prapullac prapullac added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marks0351 marks0351

Labels
App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request Verified When issue is retested post its fixed
Projects
No open projects
UI Building
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature Switch Widget appsmithorg/appsmith
5 participants
@Nikhil-Nandagopal @areyabhishek @marks0351 @prapullac @appsmith-bot