Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Reusing a saved datasource does not auto-import the headers from the datasource in the API pane #2143

Closed
nidhi-nair opened this issue Dec 11, 2020 · 1 comment · Fixed by #4481
Closed

[Bug] Reusing a saved datasource does not auto-import the headers from the datasource in the API pane #2143

nidhi-nair opened this issue Dec 11, 2020 · 1 comment · Fixed by #4481
Assignees
@arunvjn
Labels
Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Frontend This label marks the issue or pull request to reference client code Verified When issue is retested post its fixed
Projects
API Re-design

Comments

@nidhi-nair
Copy link
Contributor

Description

If a user saves headers with an API datasource, every instance of using this datasource should re-emphasize the use of these headers. They should be read-only headers displayed before all manually entered ones. These headers should also appear in the request tab of the output in the API pane.

Steps to reproduce the behaviour:

  1. Create a new API datasource, with headers
  2. Create a new API that uses this datasource
  3. Saved headers do not appear in this API
  4. On running this API, the request tab does not show the saved headers as part of the request

Important Details

  • Version: [Cloud / Self-Hosted vx.x]
  • OS: [e.g.MacOSX]
  • Browser [e.g. chrome, safari]
@nidhi-nair nidhi-nair added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Dec 11, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal added API pane and removed Needs Triaging Needs attention from maintainers to triage labels Dec 11, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal added this to To do in API Re-design via automation Dec 11, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal removed their assignment Dec 11, 2020
@mohanarpit mohanarpit added the Frontend This label marks the issue or pull request to reference client code label Dec 11, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal added Datasources Issues related to configuring datasource on appsmith Actions and removed datasources labels Dec 22, 2020
@hetunandu
Copy link
Member

This will be implemented when we redesign the datasources page

@arunvjn arunvjn self-assigned this May 10, 2021
@arunvjn arunvjn mentioned this issue May 14, 2021
Merged
7 tasks
@close-label close-label bot added the QA Needs QA attention label May 18, 2021
@prapullac prapullac added Verified When issue is retested post its fixed and removed QA Needs QA attention labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunvjn arunvjn

Labels
Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Frontend This label marks the issue or pull request to reference client code Verified When issue is retested post its fixed
Projects
No open projects
API Re-design
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/datasource request headers in api appsmithorg/appsmith
6 participants
@mohanarpit @Nikhil-Nandagopal @nidhi-nair @hetunandu @arunvjn @prapullac