Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Padding/Margin issues with containers #2446

Merged
merged 20 commits into from Feb 12, 2021
Merged

Fix: Padding/Margin issues with containers #2446

merged 20 commits into from Feb 12, 2021

Conversation

jsartisan
Copy link
Contributor

Containers were not showing any margin in the published view whenever the scrollContent was set to true.

Fixes #2259

Type of change

  • Bug fix

How Has This Been Tested?

  • Manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Pawan Kumar added 20 commits November 16, 2020 10:52
Merge branch 'master' of github.com:appsmithorg/appsmith into release
041a17a
Merge branch 'release' of github.com:appsmithorg/appsmith into release
fc563e8
Merge branch 'release' of github.com:appsmithorg/appsmith into release
93bed29
Merge branch 'release' of github.com:appsmithorg/appsmith into release
b9b88c2
Merge branch 'release' of github.com:appsmithorg/appsmith into release
ede30a8
Merge branch 'release' of github.com:appsmithorg/appsmith into release
4fceed4
Merge branch 'release' of github.com:appsmithorg/appsmith into release
fd21bb7
Merge branch 'release' of github.com:appsmithorg/appsmith into release
99fcb71
Merge branch 'release' of github.com:appsmithorg/appsmith into release
9f098d4
Merge branch 'release' of github.com:appsmithorg/appsmith into release
29bcbaf
Merge branch 'release' of github.com:appsmithorg/appsmith into release
b77d367
Merge branch 'release' of github.com:appsmithorg/appsmith into release
4028407
Merge branch 'release' of github.com:appsmithorg/appsmith into release
2f9b7ac
Merge branch 'release' of github.com:appsmithorg/appsmith into release
939fd64
Merge branch 'release' of github.com:appsmithorg/appsmith into release
daa13c8
Merge branch 'release' of github.com:appsmithorg/appsmith into release
47ec7e6
Merge branch 'release' of github.com:appsmithorg/appsmith into release
5ce3b94
Merge branch 'release' of github.com:appsmithorg/appsmith into release
8ec4cbd
Merge branch 'release' of github.com:appsmithorg/appsmith into release
6683aac
fix margin/padding issue in container in publish view
109dc68
@jsartisan jsartisan merged commit 5b23cbf into release Feb 12, 2021
@jsartisan jsartisan deleted the fix/padding-margin-containers branch February 12, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Padding/Margin issues with containers
2 participants
@jsartisan @riodeuno