Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never show the redux action type in toast errors #2635

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Never show the redux action type in toast errors #2635

merged 2 commits into from
Jan 21, 2021

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Jan 20, 2021 •
edited

Description

Don't expose app redux action types in toast errors

Fixes: #2642
Fixes: #2656

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Could not be reproduced

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hetunandu hetunandu added this to In progress in Improved Debugging for Actions via automation Jan 20, 2021
Improved Debugging for Actions automation moved this from In progress to Reviewer approved Jan 21, 2021
@hetunandu hetunandu added the Bug Something isn't working label Jan 21, 2021
@hetunandu hetunandu merged commit 4021b21 into release Jan 21, 2021
Improved Debugging for Actions automation moved this from Reviewer approved to Done Jan 21, 2021
@hetunandu hetunandu deleted the fix/dont-show-redux-action-name-in-error branch January 21, 2021 06:42
hetunandu added a commit that referenced this pull request Jan 21, 2021
@hetunandu
Never show the redux action type in toast errors (#2635)
4014e52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofpiyush ofpiyush ofpiyush approved these changes

@jsartisan jsartisan jsartisan approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
No open projects
Improved Debugging for Actions
  
Done
Milestone
No milestone
3 participants
@hetunandu @ofpiyush @jsartisan