Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] UX : API timeout option does not look like an editable field #2930

Closed
prapullac opened this issue Feb 9, 2021 · 5 comments · Fixed by #2964 or #2218
Closed

[Bug] UX : API timeout option does not look like an editable field #2930

prapullac opened this issue Feb 9, 2021 · 5 comments · Fixed by #2964 or #2218
Assignees
@Nikhil-Nandagopal @devrk96
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Verified When issue is retested post its fixed
Projects
API Re-design

Comments

@prapullac
Copy link
Contributor

Steps to reproduce:

  1. Add an API
  2. Navigate to Setting option
    and observe

Observation:

  1. The API timeout option is not visible as an editable field
  2. As we focus on the field it is highlighted with Red border.

Expectation:
In Appsmith we use red border around the field to indicate incorrect or empty mandatory field this would let user get confused.hence would recommend to have deep embedding field/ Grey coloured field.
@prapullac prapullac added Bug Something isn't working API pane Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage labels Feb 9, 2021
@prapullac prapullac added this to To do in API Re-design via automation Feb 9, 2021
@hetunandu hetunandu moved this from To do to Up Next in API Re-design Feb 10, 2021
@hetunandu hetunandu assigned devrk96 and unassigned hetunandu Feb 10, 2021
@hetunandu hetunandu removed the Needs Triaging Needs attention from maintainers to triage label Feb 10, 2021
@devrk96 devrk96 linked a pull request Feb 10, 2021 that will close this issue
Fix: API Pane Bugs #2964
Merged
@devrk96 devrk96 moved this from Up Next to Review in progress in API Re-design Feb 10, 2021
@Nikhil-Nandagopal
Copy link
Contributor

Nikhil-Nandagopal commented Feb 10, 2021 •
edited

@prapullac can you add a screenshot?

API Re-design automation moved this from Review in progress to Done Feb 10, 2021
API Re-design automation moved this from Done to Up Next Feb 10, 2021
@hetunandu hetunandu moved this from Up Next to Review in progress in API Re-design Feb 11, 2021
@hetunandu hetunandu moved this from Review in progress to Reviewer approved in API Re-design Feb 11, 2021
@hetunandu hetunandu moved this from Reviewer approved to Done in API Re-design Feb 11, 2021
@hetunandu hetunandu mentioned this issue Feb 11, 2021
Merged
@close-label close-label bot added the QA Needs QA attention label Feb 11, 2021
@prapullac
Copy link
Contributor Author

Hi Nikhil
The field is highlighted in "RED". Hence reopening the issue

Screenshot 2021-02-12 at 10 37 17 AM

@prapullac prapullac reopened this Feb 12, 2021
API Re-design automation moved this from Done to Up Next Feb 12, 2021
@prapullac prapullac removed the QA Needs QA attention label Feb 12, 2021
@Nikhil-Nandagopal
Copy link
Contributor

@prapullac I believe that is the expected behavior. Does this match the design?

@hetunandu
Copy link
Member

@Nikhil-Nandagopal this is focused state from our ads and thus this is expected

@prapullac
Copy link
Contributor Author

Closing the issue as per above comment

API Re-design automation moved this from Up Next to Done Feb 12, 2021
@prapullac prapullac added Verified When issue is retested post its fixed and removed Reopen labels Feb 12, 2021
@github-actions github-actions bot added the BE Coders Pod Issues related to users writing code to fetch and update data label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@devrk96 devrk96

Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Verified When issue is retested post its fixed
Projects
No open projects
API Re-design
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: API Pane Bugs appsmithorg/appsmith
Feature: API Pane Redesign appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @hetunandu @devrk96 @prapullac