Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart point trigger #2953

Merged
merged 7 commits into from Feb 22, 2021
Merged

Chart point trigger #2953

merged 7 commits into from Feb 22, 2021

Conversation

vicky-primathon
Copy link
Contributor

@vicky-primathon vicky-primathon commented Feb 10, 2021

Description

Added onDataPointClick action that is executed when chart data point is clicked

Fixes #2459

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@riodeuno
Copy link
Contributor

riodeuno commented Feb 16, 2021

@vicky-primathon Please fix the merge conflicts and update the code by moving the property pane config back into the chart widget. The table widget new features are now in release. Also, we have two new mandatory properties in all the property control configs: isBindProperty and isTriggerProperty

@riodeuno riodeuno merged commit 0eab199 into release Feb 22, 2021
@riodeuno riodeuno deleted the chart-point-trigger branch February 22, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Chart Point Click Event
2 participants