Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable toggle for params encoding #2968

Merged
merged 6 commits into from Feb 11, 2021
Merged

Conversation

sumitsum
Copy link
Contributor

Description

  1. Add toggle param to ActionConfiguration class.
  2. Add TCs to test toggle on/off/null.

Fixes #2897

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested via Junit TCs. Add 3 TC:

  1. for toggle set to true.
  2. for toggle set to false.
  3. for toggle see to null.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

1. Add toggle param to ActionConfiguration class.
2. Add TCs to test toggle on/off/null.
@trishaanand
Copy link
Contributor

@sumitsum : If I understood the problem clearly, this was for body of content type form url encoded, NOT the url itself. Could you please confirm the requirements?

@trishaanand
Copy link
Contributor

LGTM. Can be merged.

trishaanand
trishaanand previously approved these changes Feb 10, 2021
@sumitsum sumitsum merged commit e9e30d1 into release Feb 11, 2021
@sumitsum sumitsum deleted the feature/add_no_param_encode_option branch February 11, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Users would like to enable optional encoding of URI for APIs
2 participants