Fix input error on generating password and salt in install script #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens on macOS systems when a different locale is explicitly set.
This was
linked to
issues
Feb 16, 2021
mohanarpit
reviewed
Feb 16, 2021
mohanarpit
approved these changes
Feb 16, 2021
sharat87
added a commit
that referenced
this pull request
Feb 16, 2021
) * Fix potential input error on password generation This happens on macOS systems when a different locale is explicitly set. * Don't use a masked variable name (cherry picked from commit b26706c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.