Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modal Widget #3092

Merged
merged 2 commits into from Feb 23, 2021
Merged

Feature: Modal Widget #3092

merged 2 commits into from Feb 23, 2021

Conversation

marks0351
Copy link
Member

@marks0351 marks0351 commented Feb 18, 2021

Description

Adding Existing Modal widget to widget registry.

Fixes #1600

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marks0351 marks0351 changed the title Feature: Modal Widget(DIP) Feature: Modal Widget Feb 19, 2021
@marks0351 marks0351 marked this pull request as ready for review February 19, 2021 06:52
@marks0351 marks0351 merged commit d1822a9 into release Feb 23, 2021
@marks0351 marks0351 deleted the feature/modal branch February 23, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Modal should be listed as a widget so that the user can create modals from the widget pane
2 participants