Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action subtree evaluation #3142

Merged
merged 2 commits into from Feb 22, 2021
Merged

Fix action subtree evaluation #3142

merged 2 commits into from Feb 22, 2021

Conversation

hetunandu
Copy link
Member

Description

  • Action field edits were not affecting the dependency map in sub tree
  • Action config was not a binding path

The above two scenarios caused action fields to not show the latest evaluated value. This PR fixes both those issues

@hetunandu hetunandu added Bug Something isn't working Critical This issue needs immediate attention. Drop everything else labels Feb 22, 2021
@hetunandu hetunandu merged commit 6f7ce24 into release Feb 22, 2021
@hetunandu hetunandu deleted the fix/action-subtree-evaluation branch February 22, 2021 11:14
@hetunandu hetunandu mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofpiyush ofpiyush ofpiyush approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hetunandu @ofpiyush @Nikhil-Nandagopal