Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support rsa-sha2-256 and rsa-sha2-512 #32970

Closed
1 task done
hud-21326 opened this issue Apr 25, 2024 · 5 comments · Fixed by #33052 or #33166
Closed
1 task done

[Feature]: Support rsa-sha2-256 and rsa-sha2-512 #32970

hud-21326 opened this issue Apr 25, 2024 · 5 comments · Fixed by #33052 or #33166
Assignees
Labels
Critical This issue needs immediate attention. Drop everything else Enhancement New feature or request Git Pod Anything related to git sync Git Version Control Issues related to version control QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@hud-21326
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Add rsa-sha2-256 or rsa-sha2-512 as options when creating an SSH key in Appsmith for Git integration.

Why should this be worked on?

Azure DevOps is currently deprecating support for SSH-RSA keys. It also does not support ECDSA keys. Since those are the only two SSH key types that can be generated in Appsmith, this seems to break the integration between DevOps and Appsmith

@hud-21326 hud-21326 added the Enhancement New feature or request label Apr 25, 2024
@lbustelo
Copy link

+1 We just started experiencing this issue today.

@jhu8
Copy link

jhu8 commented Apr 25, 2024

+1 We use Azure as our git provider and started experiencing issues with our git integration today as well.

@nidhi-nair
Copy link
Contributor

Sorry that you have had to face such a disruption so abruptly folks! We're looking into this and will keep you updated on progress.

@nidhi-nair nidhi-nair added the Git Version Control Issues related to version control label Apr 26, 2024
@github-actions github-actions bot added the Git Pod Anything related to git sync label Apr 26, 2024
@appsmith-bot appsmith-bot added the QA Needs QA attention label Apr 30, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Apr 30, 2024
@amenasse
Copy link

amenasse commented May 1, 2024

Just wanted to get some clarification on the fix, #33052 seems to address a different problem - atomic commits not being supported by Azure Devops.

When generating keys and connecting does the appsmith git integration use one of the supported SSH signing algorithms suppoted by Azure Devops mentioned in the initial ticket description and linked article ? We are seeing behaviour that could be related to the depreciation schedule mentioned

@nidhi-nair
Copy link
Contributor

Hey @amenasse , thanks for raising your concern. While investigating this problem we discovered that since we introduced atomic pushes, all of Azure operations were affected. The earlier PR was to address that blocker and unblock folks that were only intermittently affected by the brownout phase that Azure's deprecation is in.

We hadn't been able to reproduce and hence successfully test our solution for moving on the SHA2 signing algorithms until very recently, but that's affected our test repositories as well now, so we're on our way to solving the issue. I'll re-open the issue so that the original intent is taken care of as well. Thanks for pitching in. 🙂

@nidhi-nair nidhi-nair reopened this May 3, 2024
@nidhi-nair nidhi-nair added the Critical This issue needs immediate attention. Drop everything else label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical This issue needs immediate attention. Drop everything else Enhancement New feature or request Git Pod Anything related to git sync Git Version Control Issues related to version control QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
7 participants