Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: REST API & GraphQL OAuth2 response - Add support for expiresAt key #33900

Closed
NilanshBansal opened this issue Jun 1, 2024 · 2 comments
Assignees
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration OAuth OAuth related bugs or features Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

In our codebase we are only relying on expires_in or expires_at keys in the response to check for expiry time. We should update the code for handling the expiresAt key as well which will help all our customers automatically refresh their token without the need for explicitly adding the expiry time as an input.

Code references

Object expiresAtResponse = response.get(Authentication.EXPIRES_AT);
Object expiresInResponse = response.get(Authentication.EXPIRES_IN);
and
public static final String EXPIRES_AT = "expires_at";
public static final String EXPIRES_IN = "expires_in";

@NilanshBansal NilanshBansal added Task A simple Todo OAuth OAuth related bugs or features Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Jun 1, 2024
@NilanshBansal NilanshBansal self-assigned this Jun 1, 2024
@github-actions github-actions bot added Integrations Pod Issues related to a specific integration labels Jun 1, 2024
@alpha951
Copy link

alpha951 commented Jun 1, 2024

Hey 👋, I'm looking for making my first contribution in appsmith . Could you please assign this issue to me?

@NilanshBansal NilanshBansal closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
@NilanshBansal
Copy link
Contributor Author

Hey, this might not be required as most OAuth systems only use the keys that appsmith already handles for.

Can you please pick up some issues with the label Good First Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration OAuth OAuth related bugs or features Task A simple Todo
Projects
None yet
Development

No branches or pull requests

2 participants