Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][UI Performance] Saving a page seems to block UI thread #4973

Closed
2 tasks
riodeuno opened this issue Jun 8, 2021 · 1 comment
Closed
2 tasks

[Bug][UI Performance] Saving a page seems to block UI thread #4973

riodeuno opened this issue Jun 8, 2021 · 1 comment
Assignees
Labels
Bug Something isn't working Epic A zenhub epic that describes a project Needs Triaging Needs attention from maintainers to triage UI Builders Pod Issues that UI Builders face using appsmith UI Performance Issues related to UI performance

Comments

@riodeuno
Copy link
Contributor

riodeuno commented Jun 8, 2021

Description

The auto-save feature works by saving edits to the page's properties in a debounced manner.

A user reported that their UI thread is blocked while they're in the middle of editing a property like a widget's name, it was noted that the page was in the middle of being saved when the UI thread freeze occurred.

Next steps

  • Triage issue and figure out the cause for the UI thread block
  • Figure out a different, non-blocking approach for the auto save or prevent the UI from blocking while saving.

Important Details

  • Version: 1.5.3.2
  • Environment production
@riodeuno riodeuno added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage UI Performance Issues related to UI performance labels Jun 8, 2021
@riodeuno riodeuno added the Epic A zenhub epic that describes a project label Jun 11, 2021
@SatishGandham
Copy link
Contributor

UI freezes because the whole canvas is rendered when a property changes, it's not because of the save or the network request.
This should be improved as a result of this
#4992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Epic A zenhub epic that describes a project Needs Triaging Needs attention from maintainers to triage UI Builders Pod Issues that UI Builders face using appsmith UI Performance Issues related to UI performance
Projects
None yet
Development

No branches or pull requests

4 participants