Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Install script fails without helpful message if curl fails on line install.sh:338 #579

Closed
srijanshetty opened this issue Sep 18, 2020 · 2 comments · Fixed by #581
Closed

[BUG] Install script fails without helpful message if curl fails on line install.sh:338 #579

srijanshetty opened this issue Sep 18, 2020 · 2 comments · Fixed by #581
Assignees
@mohanarpit @Nikhil-Nandagopal
Labels
Bug Something isn't working

Comments

@srijanshetty
Copy link
Contributor

Description

curl failed on line install.sh:338 and the script exited without any helpful message

Steps to reproduce the behaviour:

Add steps to reproduce this behaviour, include console / network logs & screenshots

  1. Run install script
  2. If curl fails, no helpful message is seen

Important Details

  • Version: [release v1.2.4]
  • OS: [Ubuntu 20.04]
@srijanshetty srijanshetty added the Bug Something isn't working label Sep 18, 2020
This was referenced Sep 18, 2020
Closed
Merged
@Nikhil-Nandagopal
Copy link
Contributor

@srijanshetty thank you for the issue and the fix! Will prioritise getting this reviewed

@Nikhil-Nandagopal Nikhil-Nandagopal linked a pull request Sep 19, 2020 that will close this issue
fix: use trap to run bye on errexit #581
Merged
@mohanarpit
Copy link
Member

Thanks @srijanshetty for this PR! 🎉

This has been merged into our release branch. Will be available on master in Appsmith's next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanarpit mohanarpit

@Nikhil-Nandagopal Nikhil-Nandagopal

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use trap to run bye on errexit srijanshetty/appsmith
3 participants
@mohanarpit @srijanshetty @Nikhil-Nandagopal