-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Change first day of the week on the date-picker widget #6842
Comments
Looks good can i pick this up @ayushpahwa |
Hi @Hyperion101010 , 👋 the issue is all yours! Do raise a PR within 4 days and read our Contributing.md |
Hello @Nikhil-Nandagopal are you still working on this? @Nikhil-Nandagopal can I pick this up? I have looked into this and come up with two possible solutions:
Let me know your thoughts. |
@OladapoAjala go for it! We can do both, detect the current locale and set that as the default as well as give the user an option |
Hello @Nikhil-Nandagopal thanks for assigning this issue to me. There are a couple of challenges here tho: Firstly
Secondly
|
@OladapoAjala to find existing property and add new once as well, Please take a look at the This problem is resolved with the new property introduced by blueprint |
Hello @somangshu thanks for the info. I have solved this problem by passing in an object containing the firstDayOfWeek into the dayPickerProps into the DateInput component. I am however stuck at implementing a drop-down in the date-picker property pane that dynamically passes values to the DateInput component (basically how do you access data from the property pane and pass it in as a prop into the widget's component?). |
@OladapoAjala the property given in the widget is accessible in the component with Let me know if you still have a question |
Thanks @somangshu I'd work on this over the weekend and give a feedback soon, been a bit busy lately! |
Summary
We should be able to change the first day of the week on the date picker widget.
Motivation
As requested by a user on discord.
The text was updated successfully, but these errors were encountered: