Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TyphoonInjectedAsCollection should use composition instead of inheritance #159

Closed
jasperblues opened this issue Feb 1, 2014 · 1 comment
Closed

TyphoonInjectedAsCollection should use composition instead of inheritance #159

jasperblues opened this issue Feb 1, 2014 · 1 comment
Assignees
@jasperblues
Labels
code-quality ready-for-review

Comments

@jasperblues
Copy link
Member

TyphoonInjectedAsCollection is used for both initializer injection and property injection, yet it extends from TyphoonInjectedProperty . . feels clunky.
@ghost ghost assigned jasperblues Feb 1, 2014
@jasperblues
Copy link
Member Author

Done. . . marked 'ready-for-review', but I don't think there's really much to review here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasperblues jasperblues

Labels
code-quality ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasperblues @alexgarbarev