-
Notifications
You must be signed in to change notification settings - Fork 122
/
ecl.go
504 lines (488 loc) · 12.1 KB
/
ecl.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
// Copyright (c) Contributors to the Apptainer project, established as
// Apptainer a Series of LF Projects LLC.
// For website terms of use, trademark policy, privacy policy and other
// project policies see https://lfprojects.org/policies
// Copyright (c) 2020, Control Command Inc. All rights reserved.
// Copyright (c) 2021-2022, Sylabs Inc. All rights reserved.
// This software is licensed under a 3-clause BSD license. Please consult the
// LICENSE.md file distributed with the sources of this project regarding your
// rights to use or distribute this software.
package ecl
import (
"path/filepath"
"testing"
"github.com/apptainer/apptainer/e2e/internal/e2e"
"github.com/apptainer/apptainer/e2e/internal/testhelper"
"github.com/apptainer/apptainer/internal/pkg/buildcfg"
"github.com/apptainer/apptainer/internal/pkg/syecl"
)
// KeyMap contains test keys.
var KeyMap = map[string]string{
"key1": "0C5B8C9A5FFC44E2A0AC79851CD6FA281D476DD1",
"key2": "78F8AD36B0DCB84B707F23853D608DAE21C8CA10",
}
type ctx struct {
env e2e.TestEnv
}
//nolint:maintidx
func (c *ctx) eclConfig(t *testing.T) {
tmpDir, remove := e2e.MakeTempDir(t, "", "ecl-", "ECL")
pgpDir, _ := e2e.MakeKeysDir(t, tmpDir)
c.env.KeyringDir = pgpDir
signed := filepath.Join(tmpDir, "signed.sif")
signedOne := filepath.Join(tmpDir, "signed_one.sif")
unsigned := filepath.Join(tmpDir, "unsigned.sif")
defer func() {
fn := func(t *testing.T) {
err := syecl.PutConfig(syecl.EclConfig{}, buildcfg.ECL_FILE)
if err != nil {
t.Errorf("while disabling ecl config: %s", err)
}
}
e2e.Privileged(fn)(t)
c.env.KeyringDir = ""
remove(t)
}()
tests := []struct {
name string
command string
args []string
profile e2e.Profile
consoleOps []e2e.ApptainerConsoleOp
config *syecl.EclConfig
exit int
err string
}{
{
name: "import key1 local",
command: "key import",
profile: e2e.UserProfile,
args: []string{"testdata/ecl-pgpkeys/key1.asc"},
consoleOps: []e2e.ApptainerConsoleOp{
e2e.ConsoleSendLine("e2e"),
},
exit: 0,
},
{
name: "import key2 local",
command: "key import",
profile: e2e.UserProfile,
args: []string{"testdata/ecl-pgpkeys/key2.asc"},
consoleOps: []e2e.ApptainerConsoleOp{
e2e.ConsoleSendLine("e2e"),
},
exit: 0,
},
{
name: "import key1 global",
command: "key import",
profile: e2e.RootProfile,
args: []string{"--global", "testdata/ecl-pgpkeys/pubkey1.asc"},
exit: 0,
},
{
name: "import key2 global",
command: "key import",
profile: e2e.RootProfile,
args: []string{"--global", "testdata/ecl-pgpkeys/pubkey2.asc"},
exit: 0,
},
{
name: "build signed image",
command: "build",
profile: e2e.UserProfile,
args: []string{signed, e2e.BusyboxSIF(t)},
exit: 0,
},
{
name: "build unsigned image",
command: "build",
profile: e2e.UserProfile,
args: []string{unsigned, signed},
exit: 0,
},
{
name: "build single signed image",
command: "build",
profile: e2e.UserProfile,
args: []string{signedOne, signed},
exit: 0,
},
{
name: "sign image with key1",
command: "sign",
profile: e2e.UserProfile,
args: []string{"-k", "0", signed},
consoleOps: []e2e.ApptainerConsoleOp{
e2e.ConsoleSendLine("e2e"),
},
exit: 0,
},
{
name: "sign image with key2",
command: "sign",
profile: e2e.UserProfile,
args: []string{"-k", "1", signed},
consoleOps: []e2e.ApptainerConsoleOp{
e2e.ConsoleSendLine("e2e"),
},
exit: 0,
},
{
name: "single image signature with key1",
command: "sign",
profile: e2e.UserProfile,
args: []string{"-k", "0", signedOne},
consoleOps: []e2e.ApptainerConsoleOp{
e2e.ConsoleSendLine("e2e"),
},
exit: 0,
},
{
name: "run with ECL without execgroup",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
},
args: []string{signed, "true"},
exit: 255,
},
{
name: "run with whitelist key1 and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"]},
},
},
},
args: []string{signed, "true"},
exit: 0,
},
{
name: "make sure kernel squashfs is used with ECL and default config",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"]},
},
},
},
args: []string{signed, "sh", "-c", e2e.Findsquash},
exit: 1,
},
{
name: "run with whitelist key2 and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 0,
},
{
name: "run with whitelist key1 and unsigned image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"]},
},
},
},
args: []string{unsigned, "true"},
exit: 255,
},
{
name: "run with whitelist no key and unsigned image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
},
},
},
args: []string{unsigned, "true"},
exit: 255,
},
{
name: "run with whitelist fake directory and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: "/",
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{unsigned, "true"},
exit: 255,
},
{
name: "run with whitestrict and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitestrict",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 0,
},
{
name: "run with whitestrict and single signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitestrict",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{signedOne, "true"},
exit: 255,
},
{
name: "run with whitestrict and unsigned image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitestrict",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{unsigned, "true"},
exit: 255,
},
{
name: "run with blacklist (key1) and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "blacklist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"]},
},
},
},
args: []string{signed, "true"},
exit: 255,
},
{
name: "run with blacklist (key2) and single signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "blacklist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key2"]},
},
},
},
args: []string{signedOne, "true"},
exit: 0,
},
{
name: "remove key2 from global",
command: "key remove",
profile: e2e.RootProfile,
args: []string{"--global", KeyMap["key2"]},
exit: 0,
},
{
name: "run unsigned with ecl disabled",
command: "exec",
profile: e2e.UserProfile,
args: []string{unsigned, "true"},
config: &syecl.EclConfig{}, // disable ECL
exit: 0,
},
// here we start to test additional cases for https://github.com/apptainer/apptainer/issues/578
{
name: "run with whitelist and signed image should fail",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 255, // should fail because signed key does not exist
err: "while checking container image with ECL: image not signed by required entities",
},
{
name: "run with whitelist and signed image should succeed",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitelist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 0, // should work because one of the two signed keys exists
},
{
name: "run with whitestrict and signed image should fail",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "whitestrict",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 255, // should fail because both keys should exist
err: "while checking container image with ECL: image not signed by required entities",
},
{
name: "remove key1 from global",
command: "key remove",
profile: e2e.RootProfile,
args: []string{"--global", KeyMap["key1"]},
exit: 0,
},
{
name: "run with blacklist and signed image",
command: "exec",
profile: e2e.UserProfile,
config: &syecl.EclConfig{
Activated: true,
ExecGroups: []syecl.Execgroup{
{
TagName: "group1",
ListMode: "blacklist",
DirPath: tmpDir,
KeyFPs: []string{KeyMap["key1"], KeyMap["key2"]},
},
},
},
args: []string{signed, "true"},
exit: 255, // should fail because the image is signed by forbidden keys
err: "while checking container image with ECL: image signed by a forbidden entity",
},
}
for _, tt := range tests {
cmdOps := []e2e.ApptainerCmdOp{
e2e.AsSubtest(tt.name),
e2e.WithProfile(tt.profile),
e2e.WithCommand(tt.command),
e2e.WithArgs(tt.args...),
e2e.PreRun(func(t *testing.T) {
if tt.config == nil {
return
}
fn := func(t *testing.T) {
if err := tt.config.ValidateConfig(); err != nil {
t.Errorf("while validating ecl config: %s", err)
}
err := syecl.PutConfig(*tt.config, buildcfg.ECL_FILE)
if err != nil {
t.Errorf("while creating ecl config: %s", err)
}
}
e2e.Privileged(fn)(t)
}),
e2e.ExpectExit(tt.exit, e2e.ExpectError(e2e.ContainMatch, tt.err)),
}
if tt.consoleOps != nil {
cmdOps = append(cmdOps, e2e.ConsoleRun(tt.consoleOps...))
}
c.env.RunApptainer(
t,
cmdOps...,
)
}
}
// E2ETests is the main func to trigger the test suite
func E2ETests(env e2e.TestEnv) testhelper.Tests {
c := ctx{
env: env,
}
np := testhelper.NoParallel
return testhelper.Tests{
"config": np(c.eclConfig),
}
}