Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #24 Resolved, Improved form validation in Registration page #29

Closed
wants to merge 1 commit into from
Closed

Conversation

jaykay12
Copy link
Member

Earlier, while validating our entered contact number in the contact input field of new registration activity page, it was showing our number to be a valid number on entering 3rd digit. since, any registered mobile number must be of exactly 10 digits. so, replaced the matches() function by conditional check and enhanced the validation feature. :)

@appteam-nith
Copy link
Collaborator

Sorry bad bug solving !!!!
Why ? Because you did not test.
Need more explanation ? Check out my phone number 👎
screenshot_2016-02-23-21-11-14
P.S. I think you must use both the previous method and this method. Yes, a combination of both

@jaykay12
Copy link
Member Author

Sorry. My mistake
One ques: if i simply take the input type in phone num field to b digits only, den it can resolve this bug or not????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants