Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saas backed secrets unknown flag #452

Merged

Conversation

matiasanaya
Copy link
Contributor

@matiasanaya matiasanaya commented Jan 9, 2024

Fix docker compose run --entrypoint flag for saas backed secrets

Refs:#451

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

#451

What is the new behavior?

Fixes the issue.

Does this PR introduce a breaking change?

No

Other information:

No tests added, no docs updated.

@gabrii
Copy link

gabrii commented Jan 9, 2024

Thanks!

Fix docker compose run `--entrypoint` flag for `saas <service> secrets`

Refs:apptension#451
@matiasanaya
Copy link
Contributor Author

Users will need to rebuild the CLI to get this change. Running pnpm run postinstall should do the trick.

Copy link
Contributor

@mkleszcz mkleszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the formatting issue of secretsEditor.ts file (now runCommand args could be in the single line). Will correct this in separate PR

@mkleszcz mkleszcz merged commit 0b62d6f into apptension:master Feb 6, 2024
@mkleszcz mkleszcz mentioned this pull request Feb 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants