Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workers docker issues #484

Merged
merged 3 commits into from Feb 28, 2024
Merged

fix: Workers docker issues #484

merged 3 commits into from Feb 28, 2024

Conversation

mkleszcz
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Fixes #458

This PR includes fixes for 3 different issues that was discovered during debugging #458:

  • node_modules from the host where shared to the docker containers causing issues on Windows machines
  • issue with the invalid environment variables (PATH) into workers process causing to use python3.9 instead of python3.11. This issue caused the missing module errors in the workers container.
  • missing pnpm saas emails build command when starting the local environment by pnpm saas up

What is the current behavior?

All of the issues above exists.

What is the new behavior?

  • Fixes incorrect paths in the .dockerignore files
  • Removed NX from workers CMD image
  • Added pnpm saas emails build call into pnpm saas up

Does this PR introduce a breaking change?

Nope.

@mkleszcz mkleszcz changed the title Fix/workers docker issues Fix workers docker issues Feb 27, 2024
@mkleszcz mkleszcz changed the title Fix workers docker issues fix: Workers docker issues Feb 27, 2024
@mkleszcz mkleszcz merged commit 652bd40 into master Feb 28, 2024
53 checks passed
@mkleszcz mkleszcz deleted the fix/workers-docker-issues branch February 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailcatcher/Dockerfile build is failing on initial attempt
2 participants