fix: #449 Ensure that docker volume is created when running docs locally #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pziemkowski
requested changes
Feb 28, 2024
mkleszcz
force-pushed
the
fix/docs-ensure-be-volume
branch
from
62064ae
to
8535354
Compare
pziemkowski
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Fixes #449
What is the current behavior?
There is an issue when someone will try to start the docs before the main application. There is a missing docker volume so docs won't start.
What is the new behavior?
Running create docker volume script before docs start. It will ensure that it's created before running docs even before app startup.
Does this PR introduce a breaking change?
No.