fix: Enforce emails artifact build before workers build / deploy is executed to make sure emails/renderer/index.umd.js is present #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecuted to make sure emails/renderer/index.umd.js is present
mkleszcz
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
bug fix
What is the current behavior?
Emails artifact is not built when
saas workers buildorsaas workers deployis run.What is the new behavior?
Added webapp-emails as a dependency to
workersandwebapp-emails:buildas a dependency for bothbuildanddeploytargets in workers package.Changed SSM service to workers during emails build, instead of webapp. Makes much more sense.
Does this PR introduce a breaking change?
yes. when building emails, SSM variables will be pulled from workers (use
saas workers secretsto set them) instead of webapp.