Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default values for --older-than and --keep and explain output #22

Closed
bittner opened this issue May 9, 2020 · 0 comments · Fixed by #27
Closed

Reduce default values for --older-than and --keep and explain output #22

bittner opened this issue May 9, 2020 · 0 comments · Fixed by #27
Labels
enhancement New feature or request

Comments

@bittner
Copy link
Contributor

bittner commented May 9, 2020

The commands configmap, secret and image orphans have rather high default values for:

  • --keep (default 10)
  • --older-than (default "2mo")

While this might look like a somewhat "safe" choice than a smaller number,

  1. we're talking about resources that we detect to be unused, and
  2. it's irritating to run seiso without those options and not get any results.

We may need to consider typical developer patterns of use, such as:

"I've been developing heavily this week, and now I just hit the quota limit."

To me, this sounds like a common scanario. For a case like that "2 months" makes little sense: It makes seiso tell us, "No resources found", and yields the impression that the tool is broken.

Suggested solution

  1. Reduce --keep default to 3
  2. Reduce --older-than default to 1w
  3. Explain the filters currently active in the result we print out, e.g.
    $ seiso configmaps -n myproject -l app=myapp
    Showing results for --keep=3 and --older-than=1w
    INFO Nothing found to be deleted.
@bittner bittner added the enhancement New feature or request label May 9, 2020
@bittner bittner changed the title Reduce default values for --older-than and --keep Reduce default values for --older-than and --keep and explain output May 9, 2020
@zugao zugao closed this as completed in #27 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment