Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support both uppercase Y and lowercase y in installation #6094

Closed
2 tasks done
byawitz opened this issue Aug 31, 2023 · 2 comments · Fixed by #6097
Closed
2 tasks done

Feature: Support both uppercase Y and lowercase y in installation #6094

byawitz opened this issue Aug 31, 2023 · 2 comments · Fixed by #6097
Assignees
@stnguyen90
Labels
enhancement New feature or request product / migrations Fixes and upgrades for the Appwrite Migrations.
Milestone
1.4.2

Comments

@byawitz
Copy link
Member

byawitz commented Aug 31, 2023 •
edited
Loading

👟 Reproduction steps

When upgrading to version 1.4.1 you are present with this question

Previous installation found, do you want to overwrite it (a backup will be created before overwriting)? (Y/n)

And you must insert uppercase Y to be considered as yes.

👍 Expected behavior

Lowercase should do

👎 Actual Behavior

Only uppercase

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?
@byawitz byawitz added the bug Something isn't working label Aug 31, 2023
@joeyouss joeyouss added the product / migrations Fixes and upgrades for the Appwrite Migrations. label Aug 31, 2023
@joeyouss joeyouss changed the title 🐛 Bug Report: Install accepts only Upper case Y Feature: Support both uppercase Y and lowercase y in installation Aug 31, 2023
@joeyouss joeyouss added enhancement New feature or request and removed bug Something isn't working labels Aug 31, 2023
@joeyouss
Copy link

Hey @byawitz , changed the title because it was not a bug but intended. Having an enhancement to add support for both lowercase and uppercase makes more sense. I have passed this to my team and will keep you posted if we move forward to implementation.

@byawitz
Copy link
Member Author

byawitz commented Aug 31, 2023

Makes sense

@stnguyen90 stnguyen90 self-assigned this Aug 31, 2023
@stnguyen90 stnguyen90 mentioned this issue Aug 31, 2023
Merged
2 tasks
@stnguyen90 stnguyen90 added this to the 1.4.2 milestone Aug 31, 2023
@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@stnguyen90 stnguyen90 linked a pull request Sep 1, 2023 that will close this issue
Make install confirmation case insensitive #6097
Merged
2 tasks
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stnguyen90 stnguyen90

Labels
enhancement New feature or request product / migrations Fixes and upgrades for the Appwrite Migrations.
Projects
No open projects
1.4 release
Status: Done
Milestone
1.4.2
Development

Successfully merging a pull request may close this issue.

Make install confirmation case insensitive appwrite/appwrite
3 participants
@byawitz @stnguyen90 @joeyouss