Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: Single links instead of plural one. #470

Closed
2 tasks done
byawitz opened this issue Jun 29, 2023 · 1 comment 路 Fixed by #471
Closed
2 tasks done

馃悰 Bug Report: Single links instead of plural one. #470

byawitz opened this issue Jun 29, 2023 · 1 comment 路 Fixed by #471
Labels
bug Something isn't working

Comments

@byawitz
Copy link
Member

byawitz commented Jun 29, 2023

馃憻 Reproduction steps

In this file
https://github.com/appwrite/console/blob/9174d8f8cb584744dd7a53f69d324f490ee82ee3/src/lib/layout/logs.svelte

Two dynamically generated links use a singular path instead of a plural one.

deployment instead of deployments

rawData = `${sdk.forConsole.client.config.endpoint}/functions/${$log.func.$id}/deployment/${$log.data.$id}?mode=admin&project=${$page.params.project}`;

execution instead of executions

rawData = `${sdk.forConsole.client.config.endpoint}/functions/${$log.func.$id}/execution/${$log.data.$id}?mode=admin&project=${$page.params.project}`;

馃憤 Expected behavior

Links should point to

馃憥 Actual Behavior

...

馃幉 Appwrite version

Version 1.3.x

馃捇 Operating system

Linux

馃П Your Environment

No response

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@byawitz byawitz added the bug Something isn't working label Jun 29, 2023
@joeyouss
Copy link

Thank you for the PR, I would pass this for review to the concerned team and get it reviewed ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants