code.tar.gz remains when function throws error

[rdmchr]

I got this error when I tried deploying my function:

✗ Error Request body larger than maxBodyLength limit

After exiting the CLI did not remove the code.tar.gz file it created. I believe the CLI should remove the file even if it crashes since there is no reason to leave it.

[christyjacob4]

Thank you for raising this @rdmchr . We'll look into this 🙂

[stnguyen90]

Looks like this was addressed for the case where the code is less than 5MB:

sdk-for-cli/lib/commands/functions.js

Lines 333 to 338 in b461997

	response = await client.call('post', path, {
	'content-type': 'multipart/form-data',
	}, payload).catch(err => {
	fs.unlinkSync(archivePath);
	throw err
	});

but may still happen if the code is more than 5MB:

sdk-for-cli/lib/commands/functions.js

Line 367 in b461997

response = await client.call('post', path, headers, payload);

[Vaibhav91one]

@Haimantika Can I work on this issue.

[Haimantika]

@Haimantika Can I work on this issue.

Hi @Vaibhav91one , I've assigned the issue to you! Happy Hacktoberfest 🎃!

Notes:

Please update us with your progress every 3 days, so that we know you are working on it.
Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

[Vaibhav91one]

@Haimantika Can I work on this issue.

Hi @Vaibhav91one , I've assigned the issue to you! Happy Hacktoberfest 🎃!

Notes:

Please update us with your progress every 3 days, so that we know you are working on it. Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

I just wanted to give an update. That I am working on this and talking to some people related to this issue.

[Vaibhav91one]

Will be making a PR soon.

[Vaibhav91one]

Will be making a PR soon.

@stnguyen90 Have made a PR please review

[Haimantika]

Will be making a PR soon.

@stnguyen90 Have made a PR please review

Can you link the issue to the PR?

[Vaibhav91one]

Will be making a PR soon.

@stnguyen90 Have made a PR please review

Can you link the issue to the PR?

#99

[Souptik2001]

Hey @stnguyen90 Can you please assign me this issue.