New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Bug Report: WidgetsBinding.instance?.removeObserver #64
Comments
These warnings are from the |
For now these are just warnings and doesn't affect the functionality. |
@Appwrite-Guru You can add this to your pubspec to make those warnings go away: dependency_overrides:
flutter_web_auth:
git:
url: https://github.com/noga-dev/flutter_web_auth.git
ref: ee3c26a530a625c3cab7e0c45cc30316c8b4b64c |
I think think the dependency should be replaced with https://pub.dev/packages/flutter_web_auth_2 which is an updated fork of the apparently abandoned original flutter_web_auth. The current dependency's last update was in Feb, and given there are a number of PRs going unanswered I think we can call it what it is - abandoned. The link above is the continuation of the excellent package but with relevant fixes. I for one have an issue wanting to release production grade code but don't want to link to a dependency override. I can't guarantee that fork will be around forever as it's not a published version. I'm also sick of seeing the stupid exceptions in my console. Can we please update? If not, I'll have to look at forking appwrite/sdk_for_flutter or the generator so I can put something sound into production. From the author: If you used flutter_web_auth correctly (and without extra hackage) before, it should be sufficient to replace the following strings everywhere (yes, also in AndroidManifest.xml for example): FlutterWebAuth -> FlutterWebAuth2 |
I forked the I had to update I've tested the forked version with GitHub OAuth in a Flutter web app and all is working as expected with clean console output. I have access to the GitHub access token with the scopes requested in the session and I'm not seeing any issues at all. Upgrading has also permitted me to use the latest I have not tested Android, iOS, Windows, Mac or Linux, but I am happy to. Before you say it: I know I can't submit this as a PR because this is the read-only repo, but I am happy to fork the SDK generator and make the required changes and submit a PR there if you're interested. Just need to know if you're happy for me to proceed, or is someone else (@lohanidamodar) already tackling this? |
@jocubeit I think you can go ahead and implement the new dependency, this will also help us ensure all tests are running properly. @lohanidamodar has reached out to the maintainer of |
Alright great! I'll go ahead and create a PR. Thanks for the swift response. |
Thank you everyone for all the help, version 7.0 with the fix has been released 馃挋 More info and credits to you all in our latest blog post: https://dev.to/appwrite/announcing-new-versions-for-appwrites-flutter-and-dart-sdks-4l5j |
馃憻 Reproduction steps
Hi.
I updated my appwrite version to the latest one and now I see this red warnings in the console.
Please take a look.
馃憤 Expected behavior
clear console
馃憥 Actual Behavior
Red warnings in the console
馃幉 Appwrite version
Different version (specify in environment)
馃捇 Operating system
MacOS
馃П Your Environment
Latest version
馃憖 Have you spent some time to check if this issue has been raised before?
馃彚 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: