Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change user_id field in signature data to more general user #49

Closed
apragacz opened this issue May 6, 2019 · 1 comment
Closed

Change user_id field in signature data to more general user #49

apragacz opened this issue May 6, 2019 · 1 comment

Comments

@apragacz
Copy link
Owner

apragacz commented May 6, 2019

This should be done after #48 will be done.
From #48:

I guess the initial solution could be leaving the name user_id but allow the user identification field to be changed, and then make the change user_id -> user in next major version (0.5.0?, 1.0.0?). Probably user_id should be deprecated first, and then removed altogether.

IMPORTANT: please remember to provide backward compatibility for the deprecated user_id in the verification views (log a deprecation warning when user_id is used?), then remove it altogether in next major version.

@apragacz
Copy link
Owner Author

apragacz commented Apr 4, 2024

Decided to not work on it as it does not give a lot of value/cost

@apragacz apragacz closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant