Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing documentation in the book #14

Closed
ms82494 opened this issue Apr 26, 2020 · 1 comment
Closed

missing documentation in the book #14

ms82494 opened this issue Apr 26, 2020 · 1 comment

Comments

@ms82494
Copy link

ms82494 commented Apr 26, 2020

Hi,

I am reading the electronic version of your book on Scribd, so maybe that's abridged and my notes don't apply to the paper version. Just in case they do,

  1. I saw no mention of this repo in the text. So when I read on p.46 pip3 install -r requirements.txt I was wondering which requirements.txt file you were referring to. I went to the APress site on a hunch and found the link to the downloads there.
  2. Just following along, once I had the bot set up and issued the first /fetch order, the bot threw an error message because I didn't have a Reddit Client ID or Client Secret (see screenshot)
    Screenshot 2020-04-26 at 3 25 24 PM

The error message is fortunately descriptive, so I was able to generate those. But that step could have been documented.

Other than that, I really enjoy the book.

Thanks,
Matt

@SathyaBhat
Copy link
Collaborator

Hi Matt,

Thank you for the feedback.

  1. Yes, that was an oversight
  2. Reddit made auth mandatory shortly after the book was published, so I put in the detailed error message so that readers could fix it.

I am glad you liked the book.

(ps: I had no idea the book was on scribd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants