Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagStandard52h13 and TagCustom48h12 is not getting detected #61

Closed
easedroid opened this issue Nov 5, 2019 · 4 comments
Closed

TagStandard52h13 and TagCustom48h12 is not getting detected #61

easedroid opened this issue Nov 5, 2019 · 4 comments

Comments

@easedroid
Copy link

easedroid commented Nov 5, 2019

I have no issue with fewer number of tag id's like Tag36h10, Tag36h11 but when I tried with TagStandard52h13 with help of JNI function but my application got crashed. Please help, This is the first time I am using Apriltag. I have followed all the steps as guided in the wiki. There is something wrong in my process while using TagStandard52h13.

I have followed the steps like below.

image_u8_t* im = image_u8_create_from_pnm("test.png");
apriltag_detector_t *td = apriltag_detector_create();
apriltag_family_t *tf = tagStandard52h13_create();
apriltag_detector_add_family(td, tf);
zarray_t *detections = apriltag_detector_detect(td, im);

for (int i = 0; i < zarray_size(detections); i++) {
apriltag_detection_t *det;
zarray_get(detections, i, &det);

// Do stuff with detections here.

}
// Cleanup.
tagStandard52h13_destroy(tf);
apriltag_detector_destroy(td);

But no tags are being detected.

@iTronTik
Copy link

iTronTik commented Jan 9, 2020

Hello,

Are you able to detect it? I am getting an error saying reduce the max hemming distance.

@andnovar
Copy link

Once you reduce the max hamming distance is still breaking. I have been looking into the code and seems like a problem at initialization. family->impl is not referenced when passing to apriltag_detector_add_family_bits in apriltag.c . I guess is something with the tagCustom48h12_create function. However, it runs normally if executed directly from a C project but not as a dll called from an external program.

@easedroid
Copy link
Author

Once you reduce the max hamming distance is still breaking. I have been looking into the code and seems like a problem at initialization. family->impl is not referenced when passing to apriltag_detector_add_family_bits in apriltag.c . I guess is something with the tagCustom48h12_create function. However, it runs normally if executed directly from a C project but not as a dll called from an external program.

Are you running this on Android? If yes then this tag family won't work directly on android due to memory issue. I have tweaked it little bit and it's working on android. I will soon publish it to github

@mkrogius
Copy link
Contributor

Yes, the larger tag families can cause memory issues. You can try setting the max hamming distance to zero. Another option is to simply reduce the number of tags in that family (by editing the code, there's no more user-friendly way to reduce the number of tags yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants