Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Apps ina DB #7

Open
GiovanniSmokes opened this issue Aug 22, 2023 · 3 comments
Open

Store Apps ina DB #7

GiovanniSmokes opened this issue Aug 22, 2023 · 3 comments

Comments

@GiovanniSmokes
Copy link
Contributor

GiovanniSmokes commented Aug 22, 2023

Currently the apps are stored using file, we should change it to store in the postgres db.

@GiovanniSmokes GiovanniSmokes changed the title To-Do: Store Apps ina DB Store Apps ina DB Aug 27, 2023
@vporton
Copy link
Contributor

vporton commented Oct 16, 2023

@apssouza22 You have no objections to switch to SQL Alchemy before doing this issue?

We should do this, at least, to have a library for migrations. Working without migrations on a serious project is quite bad.

You didn't yet accept PR #52 - therefore, I ask you to avoid future merge conflicts: Should I switch to SQL Alchemy right in #52 (instead of a separate pull request that would conflict with #52) to which this issue is dependend?

@apssouza22
Copy link
Owner

Up to you.

I personally think that Migrations for projects that is not in production doesn't make much sense.

I need to test that PR again

@vporton
Copy link
Contributor

vporton commented Oct 17, 2023

I started to work rewriting the DB code in SQLAlchemy (with Alembic migrations). I didn't read the manuals of SQLAlchemy for a very long time, I am studying it anew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants