Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected switch-context multi-select behaviour #203

Closed
mikhail5555 opened this issue Feb 5, 2024 · 3 comments
Closed

Unexpected switch-context multi-select behaviour #203

mikhail5555 opened this issue Feb 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mikhail5555
Copy link

mikhail5555 commented Feb 5, 2024

Current and expected behavior

When using the Switch Context command, and going to the main screen
image

Expected Behavior:

selecting an entry and then clicking Enter I would expect to only have that single cluster selected/connected.

Current Behavior:

But as the behaviour got changed in 1.6.2, it now adds the selected cluster to the "mutli cluster" feature, requiring manually deselecting all old clusters with space (which makes switching between two clusters pretty annoying.)

Also I don't see any mention of it in the changelog, so could it be it was an accidental change?

Environment & Operating System

macOS 13.6.3
aptakube: 1.6.2

Kubectl:
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.26.0

@mikhail5555 mikhail5555 added the bug Something isn't working label Feb 5, 2024
@goenning
Copy link
Member

goenning commented Feb 5, 2024

It’s on the “improvements” section of the changelog

the intention was to make it faster to re-connect to previous clusters, but I can see how that’s annoying when switching clusters.

for now, you can press ESC and it’ll clear the selection, but I’ll review this for the next minor release.

Do you think the previous behaviour was better?
What if the preselection only happened when the launches?

@mikhail5555
Copy link
Author

mikhail5555 commented Feb 5, 2024

It’s on the “improvements” section of the changelog

the intention was to make it faster to re-connect to previous clusters, but I can see how that’s annoying when switching clusters.

for now, you can press ESC and it’ll clear the selection, but I’ll review this for the next minor release.

Do you think the previous behaviour was better? What if the preselection only happened when the launches?

Thank you for your awesome quick reply.

to answer your questions:

Do you think the previous behaviour was better?

In my opinion it was, when you do a "hard" select (like enter and or double clicking) I personaly expect only that single entry to be selected. With more "soft" selects, like space, I do expect to enter some kind of multi select mode (or holding control while clicking).

What if the preselection only happened when the launches?

I would honestly expect it to "skip" the select screen all togheter and just re-connect to the previously connected cluster(s). But it won't conflict with "quick" switching between clusters, So I don't mind.

It’s on the “improvements” section of the changelog

Ah yes I noticed that once, but from the changelog it seemed only to affect on-startup. So didn't know it was expected behavior or not

@goenning
Copy link
Member

Hi @mikhail5555 I reverted this feature on 1.6.3 until I find a better way of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants