fix failing build on hosts with wildcard dns (fixes #1230) #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1278 +/- ##
==========================================
+ Coverage 74.79% 74.81% +0.02%
==========================================
Files 144 144
Lines 16256 16248 -8
==========================================
- Hits 12158 12156 -2
+ Misses 3156 3152 -4
+ Partials 942 940 -2 ☔ View full report in Codecov by Sentry. |
neolynx
force-pushed
the
fix/test-dns
branch
2 times, most recently
from
ea6df4b
to
8ac8098
Compare
on hosts which have wildcard dns domains in their local domain search list, builds failed because "nosuch.host" could actually be resolved. Since ".host" isn't a recommended TLD by RFC2606, we use ".invalid" now. And since this is not enough to fix the problem, we use now absoulte domain names (having a '.' at the end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1231
on hosts which have wildcard dns domains in their local domain search list, builds failed because "nosuch.host" could actually be resolved.
Since ".host" isn't a recommended TLD by RFC2606, we use ".invalid" now. And since this is not enough to fix the problem, we use now absoulte domain names (having a '.' at the end)
Fixes #1230
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
AUTHORS