Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIP-84][Discussion][Retrospective] improving gas coverage #427

Closed
vgao1996 opened this issue May 20, 2024 · 0 comments
Closed

[AIP-84][Discussion][Retrospective] improving gas coverage #427

vgao1996 opened this issue May 20, 2024 · 0 comments

Comments

@vgao1996
Copy link
Contributor

AIP Discussion

This proposal improves the VM's gas coverage by introducing a few new gas charges and limits. It is is served as retroactive as the issue addresses a security vulnerability.

  • Gas for Type creation
    • Bytecode instructions and other operations that perform type instantiations, such as vec_push<T>, will incur gas charges.
  • Gas & Limits for Dependencies
    • There will be limits on the total number of dependencies and the total size of dependencies (in bytes) a transaction could have.
    • Each dependency will also incur gas charges if directly or transitively referenced by a transaction.
    • Framework modules are excluded from such calculations.

These new charges enable us to reach 100% gas coverage, ensuring fair allocation of the network's computing resources and thus the security of the network.

Read more about it here: #426

@vgao1996 vgao1996 changed the title [AIP-X][Retrospective] improving gas coverage [AIP-X][Discussion][Retrospective] improving gas coverage May 20, 2024
@vgao1996 vgao1996 changed the title [AIP-X][Discussion][Retrospective] improving gas coverage [AIP-84][Discussion][Retrospective] improving gas coverage May 21, 2024
@thepomeranian thepomeranian added this to the aptos-node-v1.10 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants