Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Prover][Compiler-v2] V2 bytecode does not work with the prover when the code contains constants #11673

Closed
rahxephon89 opened this issue Jan 17, 2024 · 3 comments
Closed

[Bug][Prover][Compiler-v2] V2 bytecode does not work with the prover when the code contains constants #11673

rahxephon89 opened this issue Jan 17, 2024 · 3 comments
Labels
bug Something isn't working compiler-v2 move-prover stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@rahxephon89
Copy link
Contributor

🐛 Bug

When the Move code contains constants such as const MAX_FRACTIONAL_PART: u128 = 0xFFFFFFFFFFFFFFFF;, constant_map is only generated V1, not V2. So when the prover tries to use the bytecode generated by V2, panic will happen because of the code here.
@rahxephon89 rahxephon89 added bug Something isn't working compiler-v2 labels Jan 17, 2024
@rahxephon89 rahxephon89 self-assigned this Jan 17, 2024
@rahxephon89 rahxephon89 added move-prover stale-exempt Prevents issues from being automatically marked and closed as stale labels Jan 17, 2024
@wrwg wrwg assigned wrwg and unassigned rahxephon89 Feb 8, 2024
@wrwg wrwg removed their assignment Feb 15, 2024
@brmataptos
Copy link
Contributor

Do we have a script/process to follow to exhibit the original bug?

@rahxephon89
Copy link
Contributor Author

Do we have a script/process to follow to exhibit the original bug?

run ENV_TEST_FEATURE=v2 cargo test test_bitvector in third_party/move/move-prover.

@rahxephon89
Copy link
Contributor Author

Confirmed that the constant map can be accessed when running the prover in V2 mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler-v2 move-prover stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rahxephon89 @wrwg @brmataptos