Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request][compiler-v2] Implement a warning for unnecessary trailing semicolon #11708

Open
vineethk opened this issue Jan 19, 2024 · 2 comments · May be fixed by #13676
Open

[Feature Request][compiler-v2] Implement a warning for unnecessary trailing semicolon #11708

vineethk opened this issue Jan 19, 2024 · 2 comments · May be fixed by #13676
Assignees
@brmataptos
Labels
compiler-v2-stable compiler-v2 enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@vineethk
Copy link
Contributor

🚀 Feature Request

Compiler v2 should implement "unnecessary trailing semicolon" warnings, some examples of which can be found here:
third_party/move/move-compiler/tests/move_check/liveness/trailing_semi.exp
@vineethk vineethk added enhancement New feature or request compiler-v2 labels Jan 19, 2024
@vineethk vineethk mentioned this issue Jan 19, 2024
Closed
@brmataptos brmataptos added the stale-exempt Prevents issues from being automatically marked and closed as stale label Jan 24, 2024
@vineethk
Copy link
Contributor Author

Some related issues: #11071, #11484

@fEst1ck fEst1ck assigned fEst1ck and unassigned fEst1ck Mar 28, 2024
@brmataptos brmataptos mentioned this issue Apr 20, 2024
Closed
@wrwg
Copy link
Contributor

wrwg commented May 23, 2024

Related #11484

@brmataptos brmataptos linked a pull request Jun 12, 2024 that will close this issue
Draft
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brmataptos brmataptos

Labels
compiler-v2-stable compiler-v2 enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: For Grabs
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a warning for an unnecessary trailing semicolon in move-compiler-v2 aptos-labs/aptos-core
4 participants
@vineethk @wrwg @fEst1ck @brmataptos