Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM] support different module publish strategies #275

Closed
zekun000 opened this issue Mar 21, 2022 · 0 comments
Closed

[VM] support different module publish strategies #275

zekun000 opened this issue Mar 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@zekun000
Copy link
Contributor

Module (re)publish is one core feature we want to support. Although we enabled open publishing in genesis, we lack of the ability to control for republish.

Currently move supports republish as long as it passes the verification. https://github.com/diem/move/blob/170ea3d47e0e2888c148872629675f698d9b1e84/language/move-vm/runtime/src/runtime.rs#L65

We'd like more granular controls and explicit on the publish strategies, e.g. support frozen modules. starcoin achieves it by adding PublishModuleBundleOption to the session api. https://github.com/starcoinorg/starcoin/blob/master/vm/vm-runtime/src/starcoin_vm.rs#L484-L498 it forks the move repo to achieve it https://github.com/starcoinorg/move/blob/starcoin-main/language/move-vm/runtime/src/move_vm_adapter.rs#L62

@zekun000 zekun000 added the enhancement New feature or request label Mar 21, 2022
@davidiw davidiw closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants