Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosetta] Allow commission percentage to be adjustable #6103

Merged
merged 1 commit into from Jan 9, 2023

Conversation

gregnazario
Copy link
Contributor

Description

Commission percentage was hardcoded to 0, this lets it be variable.

Test Plan

E2E test covers this, it's optional, so it won't do anything if not provided.

@gregnazario gregnazario enabled auto-merge (rebase) January 7, 2023 00:09
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5beb5098719d478da04f85091c1ac9212ac7b4a2

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5beb5098719d478da04f85091c1ac9212ac7b4a2 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7294 TPS, 5342 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 5beb5098719d478da04f85091c1ac9212ac7b4a2
compatibility::simple-validator-upgrade::single-validator-upgrade : 4926 TPS, 8301 ms latency, 10400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 5beb5098719d478da04f85091c1ac9212ac7b4a2
compatibility::simple-validator-upgrade::half-validator-upgrade : 4176 TPS, 9607 ms latency, 12600 ms p99 latency,no expired txns
4. upgrading second batch to new version: 5beb5098719d478da04f85091c1ac9212ac7b4a2
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6651 TPS, 5906 ms latency, 12000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 5beb5098719d478da04f85091c1ac9212ac7b4a2 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

✅ Forge suite land_blocking success on 5beb5098719d478da04f85091c1ac9212ac7b4a2

performance benchmark with full nodes : 6457 TPS, 6155 ms latency, 9000 ms p99 latency,(!) expired 260 out of 2757700 txns
Test Ok

@gregnazario gregnazario merged commit ac38220 into main Jan 9, 2023
@gregnazario gregnazario deleted the rosetta-commission-percentage branch January 9, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants