Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block-executor] Fix missing lifetime #6108

Closed
wants to merge 1 commit into from
Closed

Conversation

gregnazario
Copy link
Contributor

Description

This fails to build on Windows (but not on Mac) for some reason, unsure why it's skipped elsewhere.

Test Plan

cargo build now passes on windows instead of failing

The error prior to fixing it:

error[E0106]: missing lifetime specifier
   --> aptos-move\block-executor\src\view.rs:175:20
    |
172 |         base_view: &'a S,
    |                    -----
173 |         map: &'a BTreeMap<T::Key, T::Value>,
    |              ------------------------------
174 |         txn_idx: TxnIndex,
175 |     ) -> LatestView<T, S> {
    |                    ^ expected named lifetime parameter
    |
    = help: this function's return type contains a borrowed value with an elided lifetime, but the lifetime cannot be derived from the arguments
help: consider using the `'a` lifetime
    |
175 |     ) -> LatestView<'a, T, S> {
    |                     +++

This fails to build on Windows (but not on Mac) for some reason,
unsure why it's skipped elsewhere.
@gregnazario
Copy link
Contributor Author

This looks like it's already been solved in a different PR

@gregnazario gregnazario closed this Jan 7, 2023
auto-merge was automatically disabled January 7, 2023 19:10

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants