stop requiring the CSS file from JavaScript. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should leave that as an option for people who like to require CSS files and have a build system and process that allows that. For all other cases, it should be an option not to.
|
Totally got your point! Can you update the README as well since its a breaking change for existing users? |
|
I get it. But since this requires copy changes can you point me on how to update the README so it fits your style? |
|
... any news ? |
|
I've updated the documentation with the changes. Making a release right away @fiatjaf |
|
Version 1.4.0 released on NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should leave that as an option for people who like to require CSS files and have a build system and process that allows that.
For all other cases, it should be an option not to.